trusteddomainproject / OpenARC

Open source ARC implementation
BSD 2-Clause "Simplified" License
135 stars 45 forks source link

Simple tweak greatly improves header readability #162

Open MrPeteH opened 1 year ago

MrPeteH commented 1 year ago

It sure would be nice if this tiny tweak could be installed. I've been examining ARC headers till my brain melts down... this would make it much easier for all humans ;)

It simply places each authentication result at the start of a header sub-line, ie

ARC-Authentication-Results: .....
         dkim=pass .....;
         ...

That's how some of the Major Sites (I'm sure with their own modules) do it. @andreasschulze what do you think? (I'm using your plugin version. Working well for me, with appropriate config...)

--- openarc.c   2023-03-31 22:30:09.772713338 +0000
***************
*** 3566,3572 ****
                                        }

                                        if (n != ar.ares_count - 1)
!                                               arcf_dstring_cat(afc->mctx_tmpstr, "; ");
                                }
                        }
                }
--- 3566,3572 ----
                                        }

                                        if (n != ar.ares_count - 1)
!                                               arcf_dstring_cat(afc->mctx_tmpstr, ";\n\t");
                                }
                        }
                }
andreasschulze commented 1 year ago

@MrPeteH what do you mean with "your plugin version" ?

the line numbers above let me think you refer this code in branch 'master'. Is this correct?

MrPeteH commented 1 year ago

@andreasschulze I am almost certainly using improper vocabulary. It's this code in branch 'master' of the andreasschulze fork, which is what I've been using and looking at ;) -- Same line, same file.