search

trusteddomainproject / OpenDKIM

Other
97 stars 52 forks source link

Use a functional test for OpenSSL ed25519 support #135

Open ghen2 opened 2 years ago

ghen2 commented 2 years ago

rather than a hardcoded openssl version check, for openssl 3.0+ compatibility.

andreasschulze commented 11 months ago

this PR solve the same problem as my PR #193 in exactly the same way.

One of the PR's is obsolete

ghen2 commented 11 months ago

They're not identical, mine takes into account older openssl versions not supporting genpkey (but returning 0).

andreasschulze commented 11 months ago

Sorry, looking at your and my Version, I really see no relevant difference.

What do I miss?

ghen2 commented 11 months ago

You overlooked my second commit https://github.com/trusteddomainproject/OpenDKIM/pull/135/commits/ce8a278f9708714fceb016e97859439417cf119d.

andreasschulze commented 11 months ago

Ah, thanks, this is indeed something I wasnt's aware. So: let's take your version ...