search

trusteddomainproject / OpenDKIM

Other
97 stars 52 forks source link

Remove __P() macro for portability #140

Open orlitzky opened 2 years ago

orlitzky commented 2 years ago

The __P() macro used in e.g. https://github.com/trusteddomainproject/OpenDKIM/blob/5c539587561785a66c1f67f720f2fb741f320785/librbl/rbl.h#L62 existed only to support ancient compilers. The macro is a no-op in modern glibc,

/* These two macros are not used in glibc anymore.  They are kept here          
   only because some other projects expect the macros to be defined.  */
#define __P(args)       args
#define __PMT(args)     args

and are missing entirely in musl. So eliminating them would help make OpenDKIM build on musl without hurting anyone else (famous last words).

thegushi commented 1 year ago

Those famous last words are the ones that concern me. Let me discuss this internally.