trusteddomainproject / OpenDKIM

Other
97 stars 52 forks source link

Typo in librbl/rbl.c fails to build with -Werror on gcc14 #224

Open tjwoodall opened 3 months ago

tjwoodall commented 3 months ago
diff -ur opendkim.orig/librbl/rbl.c opendkim/librbl/rbl.c
--- opendkim.orig/librbl/rbl.c  2018-11-15 00:47:38.000000000 +0000
+++ opendkim/librbl/rbl.c       2024-08-25 12:05:44.169015382 +0000
@@ -329,7 +329,7 @@
 rbl_res_close(void *srv)
 {
 #ifdef HAVE_RES_NINIT
-       struct state *res;
+       struct __res_state *res;

        res = srv;

This appears to be a longstanding typo. c.f. dkim_res_close in libopendkim/dkim-dns.c

futatuki commented 3 months ago

Also rbl_res_nslist() has same type miss match in #ifdef HAVE_RES_SETSERVERS context.

tjwoodall commented 3 months ago

Also in int dkim_res_nslist(void srv, const char nslist) { in libopendkim/dkim-dns.c

futatuki commented 3 months ago

Also in int dkim_res_nslist(void srv, const char nslist) { in libopendkim/dkim-dns.c

Ah, I remember they were proposed to be removed in PR #99