search

trusteddomainproject / OpenDKIM

Other
97 stars 52 forks source link

Various minor fixes in sample opendkim.conf #60

Closed glts closed 4 years ago

glts commented 4 years ago

This contains very minor self-explanatory fixes mostly in sample opendkim.conf files.

Trifles, but good to have nevertheless.

orlitzky commented 4 years ago

We already fixed the PidFile in https://github.com/trusteddomainproject/OpenDKIM/pull/41, would you mind dropping that change to avoid a merge conflict if upstream ever decides to merge these?

glts commented 4 years ago

@orlitzky Fair enough, done.

orlitzky commented 4 years ago

Thanks! I'm still holding out hope.

martinbogo commented 4 years ago

In order:

The original sendmail license contains the spelling error in the Typo patch... since we're using the license verbatim the spelling is [sic] as is.

( https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/licenses/sendmail-open-source-license )

BaseDirectory -- Some utilities traditionally used /var/run, other /run to store their process related material. When these were real on disc directories it did not matter too much that these were separate directories. Today /run/ is often implemented as a tmpfs ( mount | fgrep run ) and data in those directories are fresh after every reboot. At least for the example, the older "/var/run" is correct to cover systems prior and post FHS 3.0.

( Per the linux file system hierarchy : In FHS 3.0, /var/run is replaced by /run; a system should either continue to provide a /var/run directory, or provide a symbolic link from /var/run to /run, for backwards compatibility. )

resolv.conf style vs/ unbound.conf style in the example ... it depends on what your base system is. The config styles are similar ( keyword: value ) ... why do you feel this change is needed?

glts commented 4 years ago

Fair enough.

resolv.conf style vs/ unbound.conf style in the example ... it depends on what your base system is. The config styles are similar ( keyword: value ) ... why do you feel this change is needed?

resolv.conf(5) is simply incorrect, isn’t it? When libunbound is used, ResolverConfiguration must be an Unbound configuration file, as it will be passed as-is to libunbound. Unbound has its own config file format with its own options and syntax distinct from resolv.conf. This is documented in unbound.conf(5).