search

trusteddomainproject / OpenDKIM

Other
97 stars 52 forks source link

opendkim.conf: Note more caveats for ip addresses #72

Closed kevinoid closed 4 years ago

kevinoid commented 4 years ago

After much investigation into why OpenDKIM was not behaving as expected, I found that dkimf_checkip currently checks IP addresses and CIDR blocks by repeatedly masking, converting to string using inet_ntop(3), lower-casing, and appending the mask length. This fails to match CIDR blocks with non-zero bits in the unmasked portion (e.g. 10.0.0.1/24) and addresses which did not collapse consecutive zeros in the same way as inet_ntop(3) (e.g. "0:0:0:0:0:0:0:1"). Note these restrictions in opendkim.conf(5) so that future users may be able to avoid the same issues I encountered.

Note: This PR also adds paragraph breaks to make the text more readable, given the increased length. I can easily remove this commit if it is objectionable.

martinbogo commented 4 years ago

@kevinoid

Kevin, the documentation merge looks fine -- but you're on the wrong branch. Can you please close this PR and then re-create it using the correct branch ( develop ) rather than master?

I'll be doing a big roll-up merge from develop->master at the end of the month and then tagging and creating the release.

Sincerely, Martin

kevinoid commented 4 years ago

Sure, thanks @martinbogo. Retargeted to develop branch.

kevinoid commented 4 years ago

Thanks for reviewing and merging @martinbogo!