Opendkim genzone subdomainmatch

trusteddomainproject / OpenDKIM

Other

97 stars 52 forks source link

Closed andreasschulze closed 4 years ago

andreasschulze commented 4 years ago

this PR contain modifications I use in production since ~4 years

the generated DNS records contain explicit h=sha256 as SHA1 is deprecated
do not place a timestamp in opendkim-genzone output so files created at different times are comparable
correct a logical error Murray indroduced when he merged the initial version of subdomain matching
- https://sf.net/p/opendkim/feature-requests/187/
- http://lists.opendkim.org/archive/opendkim/dev/2015/01/2037.html
be more verbose on skipped subdomains

glts commented 4 years ago

I think #64 already covers this, at least in part.

andreasschulze commented 4 years ago

yes, 8667cd2 addresses the same issue, as the text also mention

martinbogo commented 4 years ago

Please don't batch commits. One PR per issue please, and one commit set per PR.

Split this into separate PR's, and please make sure to target the development branch. @mskucherawy and I are working on and testing a new release.

andreasschulze commented 4 years ago

this PR is outdated and should be rejected, I created #77, #79, #80 and #81 ...