search

trusteddomainproject / OpenDKIM

Other
97 stars 52 forks source link

logical-error-fix #81

Closed andreasschulze closed 4 years ago

andreasschulze commented 4 years ago

replaces PR #77

correct a logical error Murray indroduced when he merged the initial version of subdomain matching

https://sf.net/p/opendkim/feature-requests/187/
http://lists.opendkim.org/archive/opendkim/dev/2015/01/2037.html

this issue is also addressed in PR #64 created by an other user (glts) but in a different way I not tried the solution from PR #64 as I know, this PR works for me

this PR is not well-formatted but this makes the logical error very visible

martinbogo commented 4 years ago

Looks OK, but really does need Murray to approve it. I've added him to the approvers/reviews list.

andreasschulze commented 4 years ago

Hi @martinbogo, @mskucherawy any news on this to get it upstream (merged into develop) ?