search

trusteddomainproject / OpenDMARC

This is the Trusted Domain Project's impementation of the DMARC protocol libary and mail filter, called OpenDMARC. A "milter" connects to unix-based mailers (originally, sendmail, but now many) and provides a standard filtering API.
Other
98 stars 52 forks source link

OPENDMARC_LIB_VERSION no longer contains version information #235

Open DrRemorse opened 1 year ago

DrRemorse commented 1 year ago

This used to contain version information:

$ grep OPENDMARC_LIB_VERSION /usr/include/opendmarc/dmarc.h

define OPENDMARC_LIB_VERSION 0x01030200

Now it contains 0x00000000. Can you check to see if perhaps a version number generator is not working?

I am currently using the following logic and hope version numbers are supported again in the future:

if (OPENDMARC_LIB_VERSION >= 0x01040000L) || (OPENDMARC_LIB_VERSION == 0x00000000L)

s = opendmarc_policy_store_dkim(dmarc, domain, selector, dkim_to_dmarc(r), comment);

else

s = opendmarc_policy_store_dkim(dmarc, domain, dkim_to_dmarc(r), comment);

endif

Thank you!

kjc75 commented 1 year ago

Appears this used to be set as part of the dist-hook Makefile target, but that's not getting triggered via the GitHub release process, and winds up remaining the default 0. I don't see it set in any of the 1.4 release packages on here.