trustedlogin / client

Easily and securely log in to your customers sites when providing support.
GNU General Public License v2.0
1 stars 3 forks source link

wp_generate_password() is misused as a secure hash generator #9

Closed Shelob9 closed 4 years ago

Shelob9 commented 4 years ago

Here, the core function wp_generate_password is used to generate some sort of hash value:

https://github.com/trustedlogin/trustedlogin-client/blob/987efd9a362a3294e921e9f64ae0f796cbc84158/src/Client.php#L501-L503

This has two key weakness:

Related #3

zackkatz commented 4 years ago

Use random_bytes() instead