search

trustedsec / CS-Situational-Awareness-BOF

Situational Awareness commands implemented using Beacon Object Files
GNU General Public License v2.0
1.28k stars 221 forks source link

bug in 'whoami' #80

Closed yanghaoi closed 2 years ago

yanghaoi commented 2 years ago

Hi, Your bof is very nice! But i fond a litter bug in zh-cn local windows, it's look like（DispName words Full display）: wrong： image True: image

yanghaoi commented 2 years ago

I try fix it , but i not found syntax error... o.0

freefirex commented 2 years ago

Hello thank you for this report.

I'm honestly not used to working with character maps outside of english. I'm having difficulty understanding what the bug is.

Is the description being cut off or is it the enabled / Disabled showing in english?

yanghaoi commented 2 years ago

Yes, the bug’s really hard to understand.I’ll try to use w_char* and LookupPrivilegeDisplayNameW fix this🤪

freefirex @.***>于2022年8月1日 周一21:05写道：

Hello thank you for this report.

I'm honestly not used to working with character maps outside of english. I'm having difficulty understanding what the bug is.

Is the description being cut off or is it the enabled / Disabled showing in english?

— Reply to this email directly, view it on GitHub https://github.com/trustedsec/CS-Situational-Awareness-BOF/issues/80#issuecomment-1201176150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFC5RPB7ESTQ7PY37IAS4QLVW7DSRANCNFSM55DKRAXA . You are receiving this because you authored the thread.Message ID: @.***>

yanghaoi commented 2 years ago

Hello, I use "LookupPrivilegeNameW" and "WideCharToMultiByte" fix the bug.

image

freefirex commented 2 years ago

Awesome, I am open to accepting a pull request if you have code that fixes the bug as stated.

Otherwise I'll address this the next time I'm going through issue lists / pull requests and working this codebase.

yanghaoi commented 2 years ago

Thanks, I’ll do it this week. 😀

freefirex @.***>于2022年8月8日 周一20:59写道：

Awesome, I am open to accepting a pull request if you have code that fixes the bug as stated.

Otherwise I'll address this the next time I'm going through issue lists / pull requests and working this codebase.

— Reply to this email directly, view it on GitHub https://github.com/trustedsec/CS-Situational-Awareness-BOF/issues/80#issuecomment-1208095716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFC5RPHXPB737UXRD64MJODVYEACRANCNFSM55DKRAXA . You are receiving this because you authored the thread.Message ID: @.***>

yanghaoi commented 2 years ago

Hello,I create a repository BOF_whoami fixes some bugs, thank you.

freefirex commented 2 years ago

This is not a pull request, its a completely separate repo.

The other issue is if I fix this here I do think I'll be obligated to make the entire code base have international support. At this time I'm unable to allocate that time to such an effort. For these reasons I'm closing this issue and will not be regarding it further.