search

trustedsec / CS-Situational-Awareness-BOF

Situational Awareness commands implemented using Beacon Object Files
GNU General Public License v2.0
1.28k stars 220 forks source link

Ldapsearch low-privileged domain user can now query nTSecurityDescriptor #90

Closed Firat-NVISO closed 1 year ago

Firat-NVISO commented 1 year ago

Fixed ldapsearch from my last pull request so low-privileged domain users can now also query for nTsecurityDescriptor of domain objects. I'm far from the best at coding C/C++, so I hope freeing of memory is done correctly.

I had to copy some files over, so Github thinks I changed whole files. In the readme.md, I changed line 33. In SA.cna, I only added some extra info in the ldapsearch section. The main changes are in ldapsearch's entry.c .

Sorry for the mess, but everything seems to work as both low-priv and high-priv domain user 😛. Also added a warning in the readme that adding nTSecurityDescriptor COULD break pagination, although everything worked fine for me. It's an optional attribute in the end.

freefirex commented 1 year ago

Hello, Just got back from holiday, I should be able to review this later this week. Thanks for the pull!

freefirex commented 1 year ago

Took a look this morning, thanks again.

I'm not going to be able to accept this pull in its current state, namely it will completely destroy git blame for telling me who did what in the future as everything in those files will point to this re-write.

What I need you to do is pull out those lines you mention as being the ones you changed, hard reset your branch to before the commit where it states the entire file was re-written, reapply your new changes and force push over so that said overwriting commit isn't in the git history anymore.

Basically, please clean up this commit such that it can be easily validated for what was changed, and proper history is maintained.

Firat-NVISO commented 1 year ago

Alright, I'll make a new pr