search

trustedsec / ptf

The Penetration Testers Framework (PTF) is a way for modular support for up-to-date tools.
5.1k stars 1.23k forks source link

revive `use` without category names #523

Closed ypcrts closed 4 years ago

ypcrts commented 4 years ago

Hey 👋

efa0cd5b2b89e255469fe6d22c4aee0651e098b2ea93bcb1547abb0872c74830c5b6a781cb29804f broke the small feature that we introduced in c3e8a9d9c79f3dda28793cc40bbde1b98374a3eb. The feature allowed the user to omit the category name, so I could type use crackmapexec instead of use modules/post-exploitation/crackmapexec.

Here's the result now:

ptf> use crackmapexec
[!] [!] DANGER WILL ROBINSON. DANGER WILL ROBINSON. Error has occurred.
[!] [!] It's not possible its due to my coding skillz, it must be you? :-)
[!] [!] Printing that error. Get that error. You get it: module not found

If I revert efa0cd5b2b89e255469fe6d22c4aee0651e098b2ea93bcb1547abb0872c74830c5b6a781cb29804f, it works again. Would you be willing to accept a patch to revive the feature and immortalize it in the docs?

It's okay to say no.

Thanks a lot for the recent quar-time updates by the way.

🐼

Edit: fixed commitish

ghost commented 4 years ago

I forgot we could call the tool directly.

ghost commented 4 years ago

how did efa0cd5 break c3e8a9d if it is only a tool? Maybe I understood it wrong

ghost commented 4 years ago

Hopfully this has been fixed in issue #524

ypcrts commented 4 years ago

Apologies, I copied the wrong commitish. Bug introduced in ea93bcb1547abb0872c74830c5b6a781cb29804f

ghost commented 4 years ago

Yeah, I thought so because it wouldn't make sense for that first one to have affected anything. Had to find out manually where the issue was actually at and then fix it. No probs though.

ghost commented 4 years ago

@ypcrts Can we close this issue since it has been fixed?

ypcrts commented 4 years ago

Fixed in https://github.com/trustedsec/ptf/commit/4ab2882bef5b929b0e7a9420601b74a7f669a346

Thanks @realagentwhite