search

trustedshops-public / connect-app-connector

part of connector layer for NewGen shop plugins
https://developers.etrusted.com/solutions/newgen-sdk/introduction.html
MIT License
1 stars 0 forks source link

Speed improvements #29

Open DomiKoch opened 1 year ago

DomiKoch commented 1 year ago

Description

Hi @Mhera17 ,

we want to comply to some requirements of shopify and improve the loading time of our connector layer in the shopify backend. image

LCP: https://shopify.dev/docs/apps/best-practices/performance/admin#largest-contentful-paint Mobile: https://shopify.dev/docs/apps/tools/app-bridge/optimized-loading

In Lighthouse Test Desktop we are slightly above the wished LCP Limit (2,5 second): image

In Lighthouse Test Mobile our connector is really bad.

Could you investigate, which issues are optimizeable

a) in Connector Layer b) need to be done in baselayer

Do you have experience with that?

Greetings Dominik

References

No response

Mhera17 commented 1 year ago

HI @DomiKoch. yes, sure I have experience with that. I have changed and now testing some stuff to have better performance.I hope I will be back soon with the result

Mhera17 commented 1 year ago

hi @DomiKoch @eburck . I made some changes to the connector and event library. Hopefully, this will help us improve the speed of our application. For EventLib, I changed the webpack configs. for the connector, I removed 3 libraries from package.Json (Lodash, yup and @hookform/resolvers). We don't need them anymore. And created a new file for the trustBadge switcher. and did some code splitting. Take a look, please. Hope this helps