trustedshops-public / etrusted-ios-trustbadge-library

Show TrustBadge on your iOS app
MIT License
2 stars 2 forks source link

Merge buyer protection currency (chf, euro, gbp, pln, nok, sek, dkk, ron and czk) support with develop branch #30

Closed prempratapsingh closed 1 year ago

prempratapsingh commented 1 year ago

Relates - https://etrustedmobile.atlassian.net/browse/MAD-215 [iOS] Trustylib V2.5 Buyer protection currency management

Description

Added buyer protection currency support for chf, euro, gbp, pln, nok, sek, dkk, ron and czk currencies. The same set of currencies are being supported by the web trustbadge component. This JS script has details about supported currencies - https://github.com/trustedshops/trustbadge/blob/main/business-logic/app/shared/format.ts

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 78.64% and project coverage change: -0.13 :warning:

Comparison is base (3452599) 84.37% compared to head (921d95e) 84.25%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #30 +/- ## =========================================== - Coverage 84.37% 84.25% -0.13% =========================================== Files 66 67 +1 Lines 2964 3062 +98 Branches 1066 1118 +52 =========================================== + Hits 2501 2580 +79 + Misses 261 259 -2 - Partials 202 223 +21 ``` | [Impacted Files](https://codecov.io/gh/trustedshops-public/etrusted-ios-trustbadge-library/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustedshops-public) | Coverage Δ | | |---|---|---| | [...stylibTests/BuyerProtectionDetailsModelTests.swift](https://codecov.io/gh/trustedshops-public/etrusted-ios-trustbadge-library/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustedshops-public#diff-VGVzdHMvVHJ1c3R5bGliVGVzdHMvQnV5ZXJQcm90ZWN0aW9uRGV0YWlsc01vZGVsVGVzdHMuc3dpZnQ=) | `68.33% <62.50%> (-1.48%)` | :arrow_down: | | [...Trustylib/Models/BuyerProtectionDetailsModel.swift](https://codecov.io/gh/trustedshops-public/etrusted-ios-trustbadge-library/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustedshops-public#diff-U291cmNlcy9UcnVzdHlsaWIvTW9kZWxzL0J1eWVyUHJvdGVjdGlvbkRldGFpbHNNb2RlbC5zd2lmdA==) | `84.21% <75.00%> (-1.51%)` | :arrow_down: | | [Sources/Trustylib/Models/CurrencyCode.swift](https://codecov.io/gh/trustedshops-public/etrusted-ios-trustbadge-library/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustedshops-public#diff-U291cmNlcy9UcnVzdHlsaWIvTW9kZWxzL0N1cnJlbmN5Q29kZS5zd2lmdA==) | `83.33% <78.94%> (ø)` | | | [Tests/TrustylibTests/CurrencyCodeTests.swift](https://codecov.io/gh/trustedshops-public/etrusted-ios-trustbadge-library/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustedshops-public#diff-VGVzdHMvVHJ1c3R5bGliVGVzdHMvQ3VycmVuY3lDb2RlVGVzdHMuc3dpZnQ=) | `80.88% <80.88%> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/trustedshops-public/etrusted-ios-trustbadge-library/pull/30/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustedshops-public) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustedshops-public). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustedshops-public)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

prempratapsingh commented 1 year ago

Looks good to me.

Thank you @irockel for reviewing the PR. I had to rebase the branch with develop branch changes (after merging PR #29), thus this PR requires re-review :)