Matching: handle composite characters correctly

trustelem / zxcvbn

Go implementation of Dropbox's zxcvbn realistic password strength estimator

MIT License

68 stars 13 forks source link

Matching: handle composite characters correctly #11

Closed itizir closed 4 years ago

itizir commented 4 years ago

As a follow-up of @stevenjohnstone's fix in https://github.com/trustelem/zxcvbn/pull/3, here's a suggestion for handling composite characters correctly, again keeping the change minimal and preserving the meaning of i and j as first and last bytes of the matched token.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 32

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 97.003%

Totals
Change from base Build 31:	0.008%
Covered Lines:	1068
Relevant Lines:	1101

💛 - Coveralls

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 32

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 97.003%

Totals
Change from base Build 31:	0.008%
Covered Lines:	2136
Relevant Lines:	2202

💛 - Coveralls

vanackere commented 4 years ago

Thanks for the fix, merged !