search

trustelem / zxcvbn

Go implementation of Dropbox's zxcvbn realistic password strength estimator
MIT License
67 stars 13 forks source link

Tests failing for `p@13296word`, `zhang198822` & `neverforget13/3/1997` #13

Closed abemedia closed 3 years ago

abemedia commented 4 years ago

The following tests are failing:

--- FAIL: TestPasswordStrength (0.05s)
    --- FAIL: TestPasswordStrength/p@13296word (0.00s)
        Error Trace:    zxcvbn_test.go:65
        Error:      Not equal: 8395 (expected)
                        != 8760 (actual)
        Messages:   Password "p@13296word", field guesses: expect={"pattern":"date","i":2,"j":6,"token":"13296","year":1996,"month":2,"day":13,"guesses":8395} got={"pattern":"date","i":2,"j":6,"token":"13296","year":1996,"month":2,"day":13,"guesses":8760}

    --- FAIL: TestPasswordStrength/zhang198822 (0.00s)
        Error Trace:    zxcvbn_test.go:65
        Error:      Not equal: 11315 (expected)
                        != 11680 (actual)
        Messages:   Password "zhang198822", field guesses: expect={"pattern":"date","i":5,"j":10,"token":"198822","year":1988,"month":2,"day":2,"guesses":11315} got={"pattern":"date","i":5,"j":10,"token":"198822","year":1988,"month":2,"day":2,"guesses":11680}

    --- FAIL: TestPasswordStrength/neverforget13/3/1997 (0.00s)
        Error Trace:    zxcvbn_test.go:65
        Error:      Not equal: 32120 (expected)
                        != 33580 (actual)
        Messages:   Password "neverforget13/3/1997", field guesses: expect={"pattern":"date","i":11,"j":19,"token":"13/3/1997","year":1997,"month":3,"day":13,"separator":"/","guesses":32120} got={"pattern":"date","i":11,"j":19,"token":"13/3/1997","year":1997,"month":3,"day":13,"separator":"/","guesses":33580}

FAIL
FAIL    github.com/trustelem/zxcvbn 0.071s
FAIL
vanackere commented 3 years ago

Thanks for the report and sorry for taking so long to respond to this...

I just fixed this in https://github.com/trustelem/zxcvbn/commit/7ff0ca8f2f7f8e085af7405917f8e2f34633c1bf