search

trustelem / zxcvbn

Go implementation of Dropbox's zxcvbn realistic password strength estimator
MIT License
68 stars 13 forks source link

remove use of regexp2 #7

Open kardianos opened 5 years ago

kardianos commented 5 years ago

Would you be willing to accept a PR that replaces the use of regexp2 with a simple parser or similar? Right now it is used for checking for repeated strings and for rough date matching, both of which seem reasonable to implement as a simple parser.

vanackere commented 5 years ago

Yes, as long as the behaviour is unchanged this looks like a worthwhile change. Thanks !

Le jeu. 16 mai 2019 à 22:33, Daniel Theophanes notifications@github.com a écrit :

Would you be willing to accept a PR that replaces the use of regexp2 with a simple parser or similar? Right now it is used for checking for repeated strings and for rough date matching, both of which seem reasonable to implement as a simple parser.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/trustelem/zxcvbn/issues/7?email_source=notifications&email_token=AAGDO6H4H3SJA3XU4WVDCU3PVXAJ7A5CNFSM4HNP6OL2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUINALQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGDO6CODD2Y3MNIHXJVUXTPVXAJ7ANCNFSM4HNP6OLQ .

vanackere commented 5 years ago

Hi @kardianos , do you still intend to implement this ?