Chore/hdk 152 d - Githubissues

trustgraph / trustgraph-holochain

Apache License 2.0

24 stars 3 forks source link

Chore/hdk 152 d #56

Closed dauphin3 closed 1 year ago

dauphin3 commented 2 years ago

Fixes #57

ocarissa commented 2 years ago

@dauphin3 check out why your tests are failing! :)

ocarissa commented 2 years ago

@dauphin3 all your checks are passing now! @harlantwood can you do Zeek's code review, or if you have already, can you approve so he can merge. 👍

ocarissa commented 2 years ago

Further to this: @dauphin3, pay mind to if this PR gets out of date with main again! We did the rebase process successfully last Friday, but it's now Monday. You may need to re-do your rebase before merge. Keep those notes we created together, handy!

harlantwood commented 2 years ago

Great work! Couple small requests.

harlantwood commented 1 year ago

Nuke it harder? 😂

dauphin3 commented 1 year ago

all good now

harlantwood commented 1 year ago

Also want to have a clean coherent commit message before merging

the current commit message is a bit of a mess:

What we want is a coherent message that tells people what has changed. Format: Summary (Blank line) bullet point 1 Bullet point 2 12:53 Example commit:

harlantwood commented 1 year ago

Superseded by #59