trustgraph / trustgraph-holochain

Apache License 2.0
24 stars 3 forks source link

Adding Pull Request Template #58

Open ocarissa opened 1 year ago

ocarissa commented 1 year ago

Add a Pull Request Template and some instruction sets on how to properly prepare a branch for merge into the main branch. We would like to propagate those docs into our numerous trustgraph public repositories so that we can promote keeping our main branches clean, clear, consistent, and decluttered for those working with us.

There was a previously opened PR #49 that is now deprecated, and this PR is the replacement for that PR. PR#49 will be closed-without-merge.

ocarissa commented 1 year ago

@harlantwood

I want to confirm before you review if we do also want the PreppingForMerge_GitCLI.md doc propagated to our public repositories too. Right now, I have added them, but if you decide you don't want those procedural guidelines in the public repos and only internal to our private repos, just let me know and I can adapt. :)

ocarissa commented 1 year ago

@harlantwood

How do I extend the time-limit for the CI checks that get run here? It says "Cancelled after 45 min." I know this is possible to extend as zeek has had to do that in the past, just not sure where that gets changed for this repo and deployment pipeline.

harlantwood commented 1 year ago

@harlantwood

I want to confirm before you review if we do also want the PreppingForMerge_GitCLI.md doc propagated to our public repositories too. Right now, I have added them, but if you decide you don't want those procedural guidelines in the public repos and only internal to our private repos, just let me know and I can adapt. :)

Let’s leave this out of the public repos, thanks 🙏

harlantwood commented 1 year ago

@harlantwood

How do I extend the time-limit for the CI checks that get run here? It says "Cancelled after 45 min." I know this is possible to extend as zeek has had to do that in the past, just not sure where that gets changed for this repo and deployment pipeline.

Check the .github/workflows YAML files. Should be a timeout setting, at least in the TG holochain repo.