search

trustification / trustify

Apache License 2.0
10 stars 19 forks source link

Provide searching for base versionless and fully-qualified packages u… #390

Closed bobmcwhirter closed 3 months ago

bobmcwhirter commented 4 months ago

…sing ?q=.

bobmcwhirter commented 4 months ago

@carlosthe19916 still [draft] but here's a shot at supporting ?q= on /api/v1/package and /api/v1/package/base depending on how wide a given search wants to be.

I suspect I don't have sorting right yet.

carlosthe19916 commented 4 months ago

One thing that I will probably request on another gh_issue is to support appropriate filtering on GET /api/v1/package?q=.... I appreciate we have multiple endpoints at the moment, but the client will use the filtering query parameters for searching "by type", "by namespace", "etc". But first things first, let's have this done and then we can discuss what to do next

image

bobmcwhirter commented 4 months ago

I'd hope filters would work already. It's using our standard Query magic from Jim.

carlosthe19916 commented 4 months ago

Cool. Looking forward to see this PR merged!

bobmcwhirter commented 3 months ago

Right on, added a test and indeed filtering by fields works as expected.

let uri = "/api/v1/package?q=type=maven";

carlosthe19916 commented 3 months ago

This PR has been approved. Whenever you are ready push the merge button :)