search

trustification / trustify

Apache License 2.0
8 stars 15 forks source link

Fixes #393. #408

Closed bobmcwhirter closed 2 weeks ago

bobmcwhirter commented 3 weeks ago

Add average_score and average_severity to the root of advisory details when fetched by key.

bobmcwhirter commented 3 weeks ago

Wait. I just put it in the commit message which has no "title"

Should it be on line 2 of the commit message to link/close?

bobmcwhirter commented 3 weeks ago

image

Links for me

jcrossley3 commented 3 weeks ago

Ah, I see. Yes, please put descriptive text on the first line, prefixed by "fix: " or "feat: " if the change warrants a blurb in the release notes, and put "Fixes: #XXX" on the next line by itself. If that's the only commit in the PR, gh will use the first line as the title and the remaining lines as the description.

If you have multiple commits, you'll need to add the "Fixes: #XXX" to the PR description yourself, never the title. The PR's title should always briefly describe what the change is.

Thanks!

jcrossley3 commented 3 weeks ago

Links for me

It will link from the commit view, but not the PR view.

bobmcwhirter commented 3 weeks ago

image

carlosthe19916 commented 2 weeks ago

Looking forward to see this being merged!