trustification / trustify

Apache License 2.0
8 stars 15 forks source link

refactor: use UUIDs as primary keys instead of integers #488

Closed ctron closed 1 week ago

ctron commented 1 week ago

Discussion: https://github.com/trustification/trustify/discussions/459

This ignores migrations and simply replaces the type. That's on purpose as explained in the discussion. It might be possible to do this actually, however that would involve:

And the same for the down migration. I just don't think it's worth the effort.

bobmcwhirter commented 1 week ago

I generally approve of this retroactive rewriting of migrations, having done an i32->UUID migration in the past, but would like to defer to @jcrossley3 if he has any opinions.

jcrossley3 commented 1 week ago

I generally approve of this retroactive rewriting of migrations, having done an i32->UUID migration in the past, but would like to defer to @jcrossley3 if he has any opinions.

I don't, other than I'd personally like to see "BREAKS MIGRATIONS" in the first line of any commit message that does.

ctron commented 1 week ago

I went with the BREAKING-CHANGE modifier (plus description) from conventional commits.