search

trustification / trustify

Apache License 2.0
10 stars 19 forks source link

Advisory - "revision" add filter #968

Closed carlosthe19916 closed 1 hour ago

carlosthe19916 commented 2 hours ago

V1 UI can filter Advisories by "Revision" date.

We need the following filter to work:

q=revision>FROM_DATE&revision<TO_DATE

Screenshot From 2024-11-05 13-18-00_2

carlosthe19916 commented 2 hours ago

The request is to make the filter work on /api/v1/advisory

carlosthe19916 commented 1 hour ago

It has been advised to use the field modified. The advice was made at https://github.com/trustification/trustify/issues/967

Closing this issue as using modified will make the filter work

jcrossley3 commented 11 minutes ago

@carlosthe19916 if it's important, we can trivially alias modified to revision so that either will work.

carlosthe19916 commented 4 minutes ago

@carlosthe19916 if it's important, we can trivially alias modified to revision so that either will work.

Thanks but I think it is fine to use modified without adding more things to the rest endpoint. I was just ignoring that the modified field was actually what we used to call revision in V1, so it was just my ignorance on matching terms.

Good to know we can add aliases though. We might need it in the future.