search

trustin / os-maven-plugin

A Maven plugin that sets various useful properties detected from ${os.name} and ${os.arch} properties.
Apache License 2.0
296 stars 66 forks source link

Removing quotes from os-release values. #14

Closed nmittler closed 8 years ago

nmittler commented 9 years ago

On certain versions of centos, the etc/os-release file contains quotes in the value strings. This leads to invalid failed matches when checking against os "like"s.

nmittler commented 9 years ago

@trustin @normanmaurer PTAL

normanmaurer commented 9 years ago

@nmittler looks good!

trustin commented 9 years ago

LGTM. You want me to release 1.4.1.Final?

nmittler commented 9 years ago

@trustin Yeah that sounds great! We probably want this before cutting the next release of Netty.

trustin commented 8 years ago

Thanks. Cherry-picked: 28a9b45b8bf7c271e118a2c6f3113c6e852a9528

trustin commented 8 years ago

1.4.1.Final should appear in the Maven central soon.