search

trustin / os-maven-plugin

A Maven plugin that sets various useful properties detected from ${os.name} and ${os.arch} properties.
Apache License 2.0
296 stars 66 forks source link

Eclipse-related documentation and metadata updates #37

Closed sergei-ivanov closed 5 years ago

sergei-ivanov commented 5 years ago
sergei-ivanov commented 5 years ago

Supplementary notes: This PR summarises various workarounds for Eclipse integration problems, as suggested by protobuf-maven-plugin community. Please see xolstice/protobuf-maven-plugin#10, xolstice/protobuf-maven-plugin#18, xolstice/protobuf-maven-plugin#41.

szab100 commented 5 years ago

Tested, works like a charm! If this gets merged, how quickly can a release be made, as this fixes major issues with Eclipse? @trustin ?

szab100 commented 5 years ago

Hey @sergei-ivanov, could you please add @trustin as a reviewer, so he might take a look when he has some time?

sergei-ivanov commented 5 years ago

I cannot appoint him as a reviewer, but he is the owner of the project and I am sure he is receiving these notifications. Please be patient: people are busy and some changes may take time.

sergei-ivanov commented 5 years ago

Related to #34

trustin commented 5 years ago

Sorry for getting late on this. Will check soon. Thanks for the head up!

trustin commented 5 years ago

Thanks a lot for your patience. Will release 1.6.1 today.