search

trustin / os-maven-plugin

A Maven plugin that sets various useful properties detected from ${os.name} and ${os.arch} properties.
Apache License 2.0
296 stars 66 forks source link

Mark DetectMojo goal with thread safety info #42

Closed seime closed 4 years ago

seime commented 4 years ago

DetectMojo should be marked with thread safety information - or big warning is shown during parallel builds

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in XXX : 
[WARNING] kr.motd.maven:os-maven-plugin:1.6.2
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************
trustin commented 4 years ago

Thanks for reporting. Are you interested in sending a pull request?

seime commented 4 years ago

@trustin PR submitted by team member :)

uweschaefer commented 4 years ago

@trustin i apologize for coming off as pushy, as you obviously are a busy man. However: Are there any plans on when to release 1.7.0? There seem to be no issues left assigned to the milestone and this fix would certainly be appreciated :laughing:

trustin commented 4 years ago

@uweschaefer I'm very sorry for not releasing a new version. Let me try some time this week. 🙇