search

trustline-inc / probity

A transparent asset-based lending protocol implemented for the EVM.
https://docs.trustline.co
Other
3 stars 1 forks source link

Product Design: Auctioneer Place Bid & buyItNow #264

Open shine2lay opened 2 years ago

shine2lay commented 2 years ago

currently implemented: When user place a bid/buyItNow for lot amount X and the auction only have amount Y (where Y < X) left to bid, X is replaced with Y and the bid will still go thru.

This same rule also apply for existing bids when we do cancelOldBids. some bids maybe lowered from their original amount to fit the remainder of lot.

Maybe we should just revert if amount X can't be fulfilled

mrosendin commented 2 years ago

We could have two versions of Auctioneer, each implementing the current or proposed design

This same rule also apply for existing bids when we do cancelOldBids

I am not seeing how the rule applies to cancelOldBids? When is cancelOldBids called...?

shine2lay commented 2 years ago

https://github.com/trustline-inc/probity/blob/main/contracts/probity/Auctioneer.sol#L465