search

trustlines-protocol / blockchain

MIT License
10 stars 7 forks source link

Determine minimal docker-compose version for quickstart #596

Closed weilbith closed 5 years ago

weilbith commented 5 years ago

It appears that the docker-compose.yaml configuration by the quickstart script does not work with a docker-compose binary version 1.17.1. This binary version does not complain about a not compatible configuration version but reports the following error:

ERROR: Invalid interpolation format for "command" option in service "home-node": "--role ${ROLE} ${ADDRESS_ARG:-} --parity-args ${AUTHOR_ARG:-}"

This error does not occur with more recent versions of docker-compose like 1.24.1. We should determine the minimum required version and document it within the related README section.

weilbith commented 5 years ago

Note: Tests before have either worked on a Digitial Ocean droplet with pre-installed Docker, which differs in the version to the default apt package of Ubuntu 18.04.3. The tests which used especially with this version were longer ago where the command looked differently. It seem to be a bug that docker-compose accepts the configuration version (which we downgraded especially for this Ubuntu binary version), but does not support all the features it should.

weilbith commented 5 years ago

Okay, apparently it was pretty close. I downloaded the releases manually and simply tried docker-compose ps within the tlbc directory of a completed quickstart setup. The next release version after 1.17.1 is 1.18.0 and it works. I can also start the service (home-node) which cased the error explicitly. I'll go to update the README.