search

trustlines-protocol / blockchain

MIT License
10 stars 7 forks source link

Use upstream prettier pre-commit hook #644

Closed ghost closed 4 years ago

ghost commented 4 years ago

That means you can stop maintaining the prettier fork with the integrated solidity plugin.

cducrest commented 4 years ago

How come we were needing it and no longer do?

ghost commented 4 years ago

How come we were needing it and no longer do?

The first time I tried to use it I couldn't get prettier to work with the solidity plugin. So, I threw it together into this prettier fork.

We did the same for shutter and I didn't want to rely on this fork. The trick is to pass the "--plugin=prettier-plugin-solidity" argument to make it work with the pre-commit managed node installation. I think I found this in the pre-commit issue tracker.