search

trustlines-protocol / clientlib

Typescript/Javascript library of the trustlines network protocol
MIT License
10 stars 7 forks source link

Add remainingData to the encoding of payment ExtraData #403

Closed cducrest closed 4 years ago

cducrest commented 4 years ago

To prepare a payment, you can now provide remainingData as arbitrary data that will be encoded into the extraData that will end up on the chain. You can still ignore this field, together with paymentRequestId and TransferId and provide custom extraData. This remainingData will also be returned in events and such. Call me if that's too ambiguous.

closes https://github.com/trustlines-network/project/issues/859

codecov-io commented 4 years ago

Codecov Report

Merging #403 (40c8c42) into master (a897659) will decrease coverage by 0.06%. The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   59.46%   59.39%   -0.07%     
==========================================
  Files          21       21              
  Lines        1485     1490       +5     
  Branches      309      311       +2     
==========================================
+ Hits          883      885       +2     
- Misses        529      532       +3     
  Partials       73       73
Flag Coverage Δ
integration 32.28% <0.00%> (-0.11%) :arrow_down:
unit 59.39% <27.27%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Payment.ts 26.92% <0.00%> (-0.21%) :arrow_down:
src/typings.ts 100.00% <ø> (ø)
src/extraData.ts 65.00% <50.00%> (-1.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a897659...40c8c42. Read the comment docs.