search

trustlines-protocol / merkle-drop

MIT License
12 stars 1 forks source link

Feature/balance #18

Closed berndbohmeier closed 5 years ago

berndbohmeier commented 5 years ago

Add command to ask for the balance of an address

Based on open PRs, so merge them first and then rebase.

Closes #14

cducrest commented 5 years ago

I get confused reviewing this PR based on an other PR that I did not review. The only comment I have is why is to_items in airdrop.py and not merkle_tree.py, and that the name of airdrop.py is unsatisfying, but I don't have better.

berndbohmeier commented 5 years ago

yea I dont like the name either but also do not have a better one. to_items is in airdrop because I tried to keep as little info about the actual data stored in the merkle tree in. I could probably move more to airdrop, but not less.