search

trustlines-protocol / merkle-drop

MIT License
12 stars 1 forks source link

Http 200 ok for non entitled addresses #40

Closed ghost closed 5 years ago

ghost commented 5 years ago

This is based on PR #39. Only the last commit is relevant.

Return '200 OK' for non entitled addresses

Previously we returned a 404 error when addresses where not contained in the merkle tree.

This is indistinguishable from trying to load from a wrong server/URL and may hide those errors from the user.

Instead we now return a normal response with originalTokenBalance set to zero and an empty proof.

codecov-io commented 5 years ago

Codecov Report

Merging #40 into master will decrease coverage by 3.61%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   78.71%   75.09%   -3.62%     
==========================================
  Files           6        6              
  Lines         249      261      +12     
==========================================
  Hits          196      196              
- Misses         53       65      +12
Impacted Files Coverage Δ
merkle_drop/server.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1787add...6de1747. Read the comment docs.