search

trustmaster / goflow

Flow-based and dataflow programming library for Go (golang)
MIT License
1.6k stars 125 forks source link

Enable golanci-lint #59

Closed akokhanovskyi closed 3 years ago

codecov-io commented 3 years ago

Codecov Report

Merging #59 into master will decrease coverage by 0.79%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   91.75%   90.96%   -0.80%     
==========================================
  Files           6        6              
  Lines         364      310      -54     
==========================================
- Hits          334      282      -52     
+ Misses         18       16       -2     
  Partials       12       12
Impacted Files Coverage Δ
graph_ports.go 84.61% <0.00%> (-2.49%) :arrow_down:
graph_iip.go 89.47% <0.00%> (-1.64%) :arrow_down:
graph_connect.go 90.84% <0.00%> (-1.02%) :arrow_down:
factory.go 100.00% <0.00%> (ø)
component.go 100.00% <0.00%> (ø)
graph.go 88.46% <0.00%> (+0.96%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d201b9...34c5bad. Read the comment docs.

akokhanovskyi commented 3 years ago

I think the goflow code could benefit from enabling golangci-lint. I intentionally disabled almost all linters so that the build would not fail and to keep changes to minimum. The .golangci.yml is default otherwise. Linters can be further enabled one by one and their reported errors fixed.

@trustmaster looking forward to your take on this.

akokhanovskyi commented 3 years ago

Not certain why the codecov complains: obviously, there are no actual code changes.

trustmaster commented 3 years ago

Nice addition! Thanks a lot @akokhanovskyi !