search

trustmaster / goflow

Flow-based and dataflow programming library for Go (golang)
MIT License
1.61k stars 125 forks source link

Enable all other happy linters, make unhappy ones explicitly disabled #60

Closed akokhanovskyi closed 3 years ago

akokhanovskyi commented 3 years ago

Enable govet and gocritic and make a few minor edits to test the CI.

codecov-io commented 3 years ago

Codecov Report

Merging #60 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files           6        6           
  Lines         318      318           
=======================================
  Hits          288      288           
  Misses         17       17           
  Partials       13       13
Impacted Files Coverage Δ
component.go 100.00% <ø> (ø)
graph_connect.go 91.19% <100.00%> (ø)
graph_iip.go 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7ab278...930b9fb. Read the comment docs.

trustmaster commented 3 years ago

@akokhanovskyi i'm a bit outdated on current tooling in Go. Is there something that can automatically fix some of the linter problems, or do you always update the code manually?

akokhanovskyi commented 3 years ago

I have not seen anything that would fix linter issues beyond the basic gofmt, goreturns, etc. - mostly dealing with formatting, so it's mostly manual.