Enable ineffassign, errcheck except in tests, minor refactoring

trustmaster / goflow

Flow-based and dataflow programming library for Go (golang)

MIT License

1.6k stars 125 forks source link

Closed akokhanovskyi closed 3 years ago

akokhanovskyi commented 3 years ago

errcheck only fails in tests, so enabled elsewhere
inefassign only had one issue, fixed by returning an error
slightly improved sendIIPs() while I was at it (keep normal flow indentation at minimum by handling error conditions early; do not use iterating variables in a goroutine, which is unsafe)

akokhanovskyi commented 3 years ago

Looks like the no-copy of the ip leads to a data race in golang 1.15. It doesn't in 1.13 - not yet sure why, but I reverted the change for now.

@trustmaster please consider squashing on merge so that there is no broken revision in the master.

trustmaster commented 3 years ago

Merged! Thanks a lot for the contribution!