search

trustmaster / goflow

Flow-based and dataflow programming library for Go (golang)
MIT License
1.6k stars 125 forks source link

Fix data race on fan-in IIP close #68

Closed trustmaster closed 3 years ago

trustmaster commented 3 years ago

This is a potential fix for #65 that uses Graph.incChanListenersCount() / Graph.decChanListenersCount() for reference counting.

Potential issues:

codecov-io commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@288dea0). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage          ?   89.74%           
=========================================
  Files             ?        6           
  Lines             ?      312           
  Branches          ?        0           
=========================================
  Hits              ?      280           
  Misses            ?       17           
  Partials          ?       15
Impacted Files Coverage Δ
graph_iip.go 83.33% <100.00%> (ø)
factory.go 100.00% <0.00%> (ø)
graph_ports.go 85.18% <0.00%> (ø)
graph_connect.go 91.30% <0.00%> (ø)
graph.go 85.18% <0.00%> (ø)
component.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 288dea0...7fd8ba8. Read the comment docs.