search

trustmaster / goflow

Flow-based and dataflow programming library for Go (golang)
MIT License
1.6k stars 125 forks source link

[WIP] Refactor graph_connect.go for better readability #69

Open akokhanovskyi opened 3 years ago

akokhanovskyi commented 3 years ago

This is WIP, please do not merge yet; comments are welcome!

codecov-io commented 3 years ago

Codecov Report

Merging #69 into master will decrease coverage by 1.85%. The diff coverage is 80.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   89.47%   87.61%   -1.86%     
==========================================
  Files           6        7       +1     
  Lines         304      323      +19     
==========================================
+ Hits          272      283      +11     
- Misses         17       26       +9     
+ Partials       15       14       -1
Impacted Files Coverage Δ
graph_connect.go 89.85% <78.94%> (-1.45%) :arrow_down:
address.go 80.95% <80.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35d1d63...f8a9e16. Read the comment docs.

codecov-commenter commented 3 years ago

Codecov Report

Merging #69 (265c5fa) into master (b48b2ee) will decrease coverage by 1.13%. The diff coverage is 84.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   89.43%   88.30%   -1.14%     
==========================================
  Files           6        7       +1     
  Lines         303      342      +39     
==========================================
+ Hits          271      302      +31     
- Misses         17       22       +5     
- Partials       15       18       +3
Impacted Files Coverage Δ
factory.go 100.00% <ø> (ø)
graph_iip.go 75.00% <33.33%> (-8.34%) :arrow_down:
graph_ports.go 75.75% <50.00%> (-9.43%) :arrow_down:
graph.go 82.97% <75.00%> (-0.70%) :arrow_down:
graph_connect.go 89.62% <77.50%> (-1.68%) :arrow_down:
address.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b48b2ee...265c5fa. Read the comment docs.