search

trustmaster / goflow

Flow-based and dataflow programming library for Go (golang)
MIT License
1.6k stars 125 forks source link

ignore nil chan , or it may cause close nil error #74

Closed v1xingyue closed 2 years ago

v1xingyue commented 2 years ago

As submited in #70. I modify this again. I have already finished running the sh test_codecov.sh . It passed all.

codecov-commenter commented 2 years ago

Codecov Report

Merging #74 (2302bfa) into master (b48b2ee) will increase coverage by 0.98%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.43%   90.42%   +0.98%     
==========================================
  Files           6        6              
  Lines         303      355      +52     
==========================================
+ Hits          271      321      +50     
- Misses         17       19       +2     
  Partials       15       15
Impacted Files Coverage Δ
graph.go 83.33% <100.00%> (-0.35%) :arrow_down:
factory.go 100.00% <0.00%> (ø)
component.go 100.00% <0.00%> (ø)
graph_connect.go 92.26% <0.00%> (+0.96%) :arrow_up:
graph_ports.go 87.50% <0.00%> (+2.31%) :arrow_up:
graph_iip.go 86.66% <0.00%> (+3.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b48b2ee...2302bfa. Read the comment docs.

trustmaster commented 2 years ago

@v1xingyue nice catch! Thanks a lot for contribution!