search

trustpilot / beat-exporter

Elastic beat-exporter for Prometheus
MIT License
207 stars 68 forks source link

rename prometheus related flags'web.listen-address' to 'web.listen-port' #1

Closed paddie closed 6 years ago

paddie commented 6 years ago

Currently the prometheus flags are under the web. prefix:

$ ./beat-exporter -help
Usage of ./beat-exporter:
  ...
  -web.listen-address string
        Address to listen on for web interface and telemetry. (default ":9479")
  -web.telemetry-path string
        Path under which to expose metrics. (default "/metrics")

I propose we put this under prom, and maybe sharpen the language a bit:

$ ./beat-exporter -help
Usage of ./beat-exporter:
  ...
  -prom.port string
        Port to listen on for web interface and telemetry. (default "9479") <-- leave out the quote
  -prom.path string
        Path under which to expose metrics. (default "/metrics")

Thoughts?

shivas commented 6 years ago

It follows prometheus and few most used exporters naming patterns, example: https://github.com/prometheus/node_exporter/blob/master/node_exporter.go#L71

paddie commented 6 years ago

I bow my heads to the prometheus precedent :)