trustpilot / beat-exporter

Elastic beat-exporter for Prometheus
MIT License
207 stars 68 forks source link

Add flag to control system metrics #31

Closed SuperQ closed 4 years ago

SuperQ commented 4 years ago

Add a boolean flag to enable system metrics. These duplicate metrics for people running the Prometheus node_exporter. But allow it to be enabled for users without node_exporter.

Signed-off-by: Ben Kochie superq@gmail.com

shivas commented 4 years ago

@SuperQ thanks for PR, can I suggest making default true? That way we won't break anything for people who already using those metrics?

SuperQ commented 4 years ago

True is the wrong value for Prometheus, as most users already have these metrics from the node_exporter.

SuperQ commented 4 years ago

And the metrics coming from system are nearly useless. Just exposing a bunch of load average data that isn't important.

shivas commented 4 years ago

@SuperQ ok, convinced :D