search

trustpilot / node-trustpilot

HTTP client for Trustpilot
MIT License
32 stars 4 forks source link

Evergreen v2 #37

Closed TPRobots closed 7 years ago

TPRobots commented 7 years ago

Pull request opened by github-pullrequestcreator.

miklosaubert commented 7 years ago

This PR contains commits from the switch-to-eslint branch, which needs to be merged first.

UPDATE: switch-to-eslint was merged, this PR starts at commit 79d5d2b

b-dur commented 7 years ago

Just curious. What are the reasons from going away from Url wrappers to a raw path based requests?

miklosaubert commented 7 years ago

The goal is to have this API client in an "evergreen" state, so that you can always use it without having to wait for new endpoints to be added, or old ones to be fixed (and, more on the maintainer side of things, we also don't need to worry about cleaning up deprecated endpoints).

Path-based requests map 1-to-1 with our API documentation and we don't need to add any documentation here.

On 3 April 2017 at 08:43, Bardur Pihl notifications@github.com wrote:

Just curious. What are the reasons from going away from Url wrappers to a raw path based requests?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/trustpilot/node-trustpilot/pull/37#issuecomment-291060754, or mute the thread https://github.com/notifications/unsubscribe-auth/AQzA2bEvsiasUFG7adM673d1v-TN92k6ks5rsJUUgaJpZM4Mv0fU .

-- MIKLOS AUBERT BACKEND DEVELOPER EMAIL mat@trustpilot.com youremail@trustpilot.com PHONE +4531155565 DK Pilestraede 58, 5th Floor, 1112 Copenhagen K https://business.trustpilot.com/ http://www.facebook.com/trustpilot https://twitter.com/trustpilotdk https://www.linkedin.com/company/trustpilot https://plus.google.com/+TrustpilotReviews/posts https://www.youtube.com/user/trustpilot We're built on trust. Read about our values. https://www.trustpilot.com/trust EMAIL CONFIDENTIALITY NOTICE This email is from Trustpilot A/S registration No. DK30276582. The email and any attachments are confidential and may contain privileged information, and are intended for the named addressee(s) only. If you have received this message in error, please notify us and remove it from your system.