search

trustpilot / plugin-magento2

Magento 2 plugin for sending invitation data to Trustpilot
MIT License
10 stars 27 forks source link

Performance issues due to cache cleaning #40

Closed hnsr closed 5 years ago

hnsr commented 5 years ago

In a project of ours we have been experiencing issues with page load times, cache lock timeouts ever since we upgraded to 2.6.437.

The cause seems to be the reinitableconfig->reinit() call in \Trustpilot\Reviews\Helper\Data::getConfig that was added in https://github.com/trustpilot/plugin-magento2/pull/39

I am unsure why this is needed so I don't how to properly fix this. For our project we simply patched away the reinit() call as a workaround, but I guess it was added for a reason

wintermute-84 commented 5 years ago

This makes it unusable on magento 2.3 Cache is locked die to the pure code implementation.

arunas-stonis commented 5 years ago

Issue was fixed in the newest release 7a8504a. Thank you for reporting it!

hnsr commented 5 years ago

Great to hear, thanks!

Op do 29 aug. 2019 12:18 schreef arunas-stonis notifications@github.com:

Issue was fixed in the newest release 7a8504a https://github.com/trustpilot/plugin-magento2/commit/7a8504a29e1224c7a2bcd16f59a41944df854b48. Thank you for reporting it!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trustpilot/plugin-magento2/issues/40?email_source=notifications&email_token=AADQIDJ4RA6BAN7EKQZ7CNDQG6O6ZA5CNFSM4IGP3Z42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5N75BA#issuecomment-526122628, or mute the thread https://github.com/notifications/unsubscribe-auth/AADQIDILCDNUKPM6ZVW4IZLQG6O6ZANCNFSM4IGP3Z4Q .