search

trustpilot / plugin-magento2

Magento 2 plugin for sending invitation data to Trustpilot
MIT License
10 stars 27 forks source link

Adminhtml JS Source map comment breaks some admin sections #64

Closed edward-simpson closed 4 years ago

edward-simpson commented 4 years ago

https://github.com/trustpilot/plugin-magento2/blob/4aa36871bdac155a854b7bf044aaed30a6dcefcf/view/adminhtml/web/js/admin.min.js#L2

This line is causing adminhtml JS issues on some pages, when JS is merged

Screenshot 2019-11-25 at 13 03 14 Screenshot 2019-11-25 at 13 03 26 Screenshot 2019-11-25 at 13 02 53
wintermute-84 commented 4 years ago

I confirm this when js merge is enabled. You should use block comments in this sort of things.

/**# sourceMappingURL=admin.min.js.map */

plainsdrifter commented 4 years ago

Hi @edward-simpson. Thank you for letting us know. It should be fixed with 2.6.524 release.

fredden commented 2 years ago

It looks like this was fixed in 2103b0a1d00d1cd982e54fafaa4d052f0f2139ff / #63.

edward-simpson commented 1 year ago

@fredden admittedly I haven't tested this yet, but from the looks of the commit all that's changed with this file is the removal of the new line at EOF, which doesn't feel like it would fix the issue

Edit: Or maybe adding a new line at EOF, it's hard to tell from the commit actually, this could potentially solve it though