search

trustpilot / plugin-magento2

Magento 2 plugin for sending invitation data to Trustpilot
MIT License
10 stars 27 forks source link

Load font-awesome.min.css via layout xml #8

Closed Tjitse-E closed 6 years ago

Tjitse-E commented 6 years ago

I suggest that we remove the @import url from view/frontend/web/css/trustpilot.css and load the external CSS file via the layout XML instead. This is a more cleaner approach, plus it gives developers the possibility to remove font-awesome.min.css via a another module.

Also, I noticed that:

      <referenceContainer name="header.container">
            <block class="Trustpilot\Reviews\Block\Head" name="trustpilot.header.head" as="trustpilot.header.head"
                   template="Trustpilot_Reviews::header/head.phtml"/>
        </referenceContainer>

Should be in a <body> tag.