trustwallet / blockatlas

Clean and lightweight cross-chain transaction API
MIT License
371 stars 229 forks source link

Refactor types.TxPage #1417

Closed hewigovens closed 3 years ago

hewigovens commented 3 years ago

Remove implicit json marshal, this needs to test a few endpoints, make sure we don't break the response json

codecov[bot] commented 3 years ago

Codecov Report

Merging #1417 (2f65001) into master (3fd5743) will decrease coverage by 0%. The diff coverage is 17%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1417   +/-   ##
======================================
- Coverage      43%     43%   -1%     
======================================
  Files         146     146           
  Lines        4100    4107    +7     
======================================
  Hits         1783    1783           
- Misses       2147    2154    +7     
  Partials      170     170           
Impacted Files Coverage Δ
pkg/blockatlas/platform.go 100% <ø> (ø)
platform/aeternity/transaction.go 74% <0%> (ø)
platform/aion/transaction.go 62% <0%> (ø)
platform/algorand/transaction.go 61% <0%> (ø)
platform/binance/transaction.go 50% <ø> (ø)
platform/bitcoin/block.go 0% <0%> (ø)
platform/bitcoin/blockbook/block.go 0% <0%> (ø)
platform/bitcoin/blockbook/client.go 0% <0%> (ø)
platform/bitcoin/blockbook/transaction.go 76% <ø> (ø)
platform/bitcoin/transaction.go 64% <0%> (+1%) :arrow_up:
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3fd5743...2f65001. Read the comment docs.