search

trustwallet / ens-coincodec

Apache License 2.0
25 stars 13 forks source link

Rework ZCash support #19

Closed optout21 closed 3 years ago

optout21 commented 3 years ago

Fixes #13 . Factored out Base58Address, and used in other address schemes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #19 into master will increase coverage by 1.59%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   94.53%   96.12%   +1.59%     
==========================================
  Files          24       24              
  Lines         494      465      -29     
==========================================
- Hits          467      447      -20     
+ Misses         14        9       -5     
+ Partials       13        9       -4
Impacted Files Coverage Δ
base58_address.go 100.00% <100.00%> (ø)
bitcoin.go 94.11% <100.00%> (+5.40%) :arrow_up:
bitcoin_forks.go 100.00% <100.00%> (ø)
ontology.go 100.00% <100.00%> (+13.33%) :arrow_up:
tezos.go 100.00% <100.00%> (ø)
tron.go 100.00% <100.00%> (+13.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 303b963...32c16d5. Read the comment docs.

optout21 commented 3 years ago

test coverage dropped 1.55%

I saw that but it is hard to believe, as I replaced much code with common code.

optout21 commented 3 years ago

To check coverage

optout21 commented 3 years ago

Coverage improved

optout21 commented 3 years ago

Coverage 94.53% 96.12% +1.59%