search

trustwallet / ens-coincodec

Apache License 2.0
25 stars 13 forks source link

Add Elrond implementation #22

Closed optout21 closed 3 years ago

optout21 commented 3 years ago

See #20 .

codecov[bot] commented 3 years ago

Codecov Report

Merging #22 (fd31db5) into master (2c98687) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   96.12%   96.17%   +0.04%     
==========================================
  Files          24       25       +1     
  Lines         465      471       +6     
==========================================
+ Hits          447      453       +6     
  Misses          9        9              
  Partials        9        9
Impacted Files Coverage Δ
bech32_address.go 100.00% <ø> (ø)
codec.go 100.00% <ø> (ø)
ethereum.go 93.93% <ø> (ø)
bnb.go 100.00% <100.00%> (ø)
cosmos.go 100.00% <100.00%> (ø)
elrond.go 100.00% <100.00%> (ø)
iotex.go 100.00% <100.00%> (ø)
zilliqa.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c98687...fd31db5. Read the comment docs.

hewigovens commented 3 years ago

always cross check with address-encoder: https://github.com/ensdomains/address-encoder/blob/master/src/__tests__/index.test.ts#L179

optout21 commented 3 years ago

Cross-checked, test was OK, added in PR #21 .