Closed optout21 closed 4 years ago
Merging #6 into master will decrease coverage by
0.52%
. The diff coverage is90.69%
.
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
- Coverage 94.86% 94.33% -0.53%
==========================================
Files 14 15 +1
Lines 331 371 +40
==========================================
+ Hits 314 350 +36
- Misses 9 11 +2
- Partials 8 10 +2
Impacted Files | Coverage Δ | |
---|---|---|
codec.go | 100% <100%> (ø) |
:arrow_up: |
test_runner.go | 90% <90%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 619a534...5789796. Read the comment docs.
Hmm, code coverage decreased, I think because I have removed a lot of duplicated test runner code, hence the basis LOC has been decreased... Real coverage has not decreased, as I kept all the existing test cases.
Coverage improved.
Each coin type had some lengthy code for running test cases, some slightly different, some with bugs. E.g. it did not handle well the cases when there was no error expected but there was error, or when there was error expected but there was no error (in this case it used the nil err value!). Test usage is unified now. Drawback: each unit test call goes to the common codec dispatcher code, not directly to the coin-specific handler method.
Further improvement: extract all test calls into a large data-only json file. Could be even factored out into an own, language-independent repo.