search

trustwallet / trust-wallet-ios

:iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS
https://trustwallet.com
GNU General Public License v3.0
1.54k stars 718 forks source link

QR code page should acknowledge incoming transaction #226

Closed bitcoinwarrior1 closed 6 years ago

ghost commented 6 years ago

@James-Sangalli what do you mean by this?

bitcoinwarrior1 commented 6 years ago

When a user opens up the qr code page there is no acknowledgement of an incoming transaction, this would be confusing to a noob.

ghost commented 6 years ago

oh, you mean showing pop up if you receive new transaction?

bitcoinwarrior1 commented 6 years ago

Yes, otherwise people may be unsure they are actually receiving payment

SmartLayer commented 6 years ago

Consider this scenario.

User a: okay, you can send me 1 Ether and I'll let you have this fridge. Buyer: Sure, I need to scan your address. User: Here is it (show his mobile phone) Buyer (Swing his phone on top of the QR code for a few rounds): Done. Now give me the fridge. User: Wait, nothing is happening on my screen. Buyer: You are using Trust Ethereum wallet, that's how it works. It's done. User: So what should I do? Buyer: click "Cancel". User: Idon't know if you have sent me the money and you are asking me to click "Cancel", what if that canceled the payment? Buyer: You silly; you can't cancel the payment. This is Ethereum. User: I don't know. I feel unconfortable when I am about to receive a payment, nothing happenes and you ask me to click "Cancel". I believe it cancel's my payment request.

So I think that Sangalli means here that user need a confirmation that a payment is sent while at the QR screen.

In fact, if user sees a payment coming REPLACING the QR screen, this visual cue would make user aware that the needed action is happening.

In fact, if it is done that way, we can as well replace "My Address" button with "Receive" button, so it stands next to "Send" button. When I use the app for the first time I was looking for "request payment" or "receive payment" button and didn't notice "My Address" actually allows me to do that. However, if I do see a "receive payment" button, I am inclined to fill a number (how much is requested) and see the option of emailing that payment request too, so perhaps we can stick to "My address" for a while until the whole flow of the 4 stages: payment-request / payment-pending / payment sent-unconfirmed / payment confirmed.

ghost commented 6 years ago

@colourful-land I got you. I will think about this UX wise. It's a problem that worth solving for sure.

johnnynanjiang commented 6 years ago

I had a look at this scenario on both iPhone and iPad, and would like to propose a couple of options as follows:

  1. To display a toast message on top of the screen when the transaction is received while the QR code screen is still on.
  2. Push notification.
  3. Change 'Cancel' button to 'Close'.
vikmeup commented 6 years ago

@johnnynanjiang as a short solution we can rename to Ok. and then show alert view for received push notification?

johnnynanjiang commented 6 years ago

@vikmeup sounds good, I will give it a go.

johnnynanjiang commented 6 years ago

Given remote notification is coming soon, will hold and see how it can be utilized for this case.

vikmeup commented 6 years ago

@johnnynanjiang I would hold on this, notifications doesn't make any sense since transactions are slow and it won't give you fast response. It's pretty rare case that we don't want to tackle at the moment.

I will close this issue, since it wasn't reported by many users, our goal to focus on solving 80% use cases for the users!